Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: report db pool metrics #644

Merged
merged 3 commits into from
Feb 27, 2024
Merged

feat: report db pool metrics #644

merged 3 commits into from
Feb 27, 2024

Conversation

pjenvey
Copy link
Member

@pjenvey pjenvey commented Feb 26, 2024

and support configuring all of deadpool's Timeouts

Closes: SYNC-4158

@pjenvey
feat: report db pool metrics
92a8a66 
and support configuring all of deadpool's Timeouts

Closes: SYNC-4158
@pjenvey pjenvey requested a review from jrconlin February 26, 2024 20:46
jrconlin
jrconlin reviewed Feb 26, 2024
View reviewed changes
Copy link
Member

@jrconlin jrconlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take it we can drop #611?

(If so, we should probably change the default GRPC port as well.

@pjenvey pjenvey requested a review from jrconlin February 26, 2024 23:05
jrconlin
jrconlin previously approved these changes Feb 26, 2024
View reviewed changes
@pjenvey pjenvey requested review from jrconlin and taddes February 27, 2024 00:15
@jrconlin jrconlin merged commit 93d4cd3 into master Feb 27, 2024
1 check passed
@jrconlin jrconlin deleted the feat/db-pool-metrics-SYNC-4158 branch February 27, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrconlin jrconlin jrconlin approved these changes

@taddes taddes Awaiting requested review from taddes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjenvey @jrconlin